feat(examples): bundler webpack todolist #11038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Size Change: +25 B (0%) Total Size: 9.85 MB
ℹ️ View Unchanged
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #11038 +/- ##
==========================================
- Coverage 29.20% 29.19% -0.02%
==========================================
Files 479 479
Lines 14393 14402 +9
Branches 3383 3388 +5
==========================================
+ Hits 4203 4204 +1
- Misses 9463 9471 +8
Partials 727 727 ☔ View full report in Codecov by Sentry. |
fz6m
reviewed
Apr 25, 2023
fz6m
reviewed
Apr 26, 2023
examples/bundler-webpack-demo/pages/todoList/components/CreateTodo/index.tsx
Outdated
Show resolved
Hide resolved
examples/bundler-webpack-demo/pages/todoList/components/CreateTodo/index.tsx
Outdated
Show resolved
Hide resolved
examples/bundler-webpack-demo/pages/todoList/components/CreateTodo/index.tsx
Outdated
Show resolved
Hide resolved
examples/bundler-webpack-demo/pages/todoList/components/Filters/index.tsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,13 @@ | |||
| export type Status = 'pending' | 'completed'; | |||
There was a problem hiding this comment.
字符串应该写成枚举，而不是 union ，未来当我们改变值时，所有的字符串都要改，这是非常大的工作量，字符串不是最佳实践。
There was a problem hiding this comment.
用字符串在项目里是无法维护的，没有人在下次改动的时候能保证一并改到所有的字符串，这相当于在给人埋坑，不是最佳实践，不能以类型的原因就极大的降低可维护性。
以下写法供参考：
export enum E {
a = 1,
b = 2,
c = 3
}
export type UnionA = E.a | E.b
export type UnionB = UnionA | E.cexport enum ESceneA {
a = 1,
b = 2
}
export enum ESceneB {
a = 1
}
export type UnionA = ESceneA
export type UnionB = ESceneA | ESceneB等等写法还有很多。
fz6m
reviewed
May 2, 2023
| const [value, setValue] = useState(''); | ||
|
|
||
| const onClick = () => { | ||
| if (!value) { |
There was a problem hiding this comment.
这个地方是隐式判断，写成 !value?.length 比较好，即使我们都是成熟的开发人员，也尽量不要在代码里写隐式转换的代码，一眼可读性比性能更重要。
| @@ -0,0 +1,13 @@ | |||
| export type Status = 'pending' | 'completed'; | |||
There was a problem hiding this comment.
用字符串在项目里是无法维护的，没有人在下次改动的时候能保证一并改到所有的字符串，这相当于在给人埋坑，不是最佳实践，不能以类型的原因就极大的降低可维护性。
以下写法供参考：
export enum E {
a = 1,
b = 2,
c = 3
}
export type UnionA = E.a | E.b
export type UnionB = UnionA | E.cexport enum ESceneA {
a = 1,
b = 2
}
export enum ESceneB {
a = 1
}
export type UnionA = ESceneA
export type UnionB = ESceneA | ESceneB等等写法还有很多。
sorrycc
approved these changes
May 4, 2023
|
这个 todo 只会作为 todo，给另一个项目验证用的。不会作为最佳实践，先合了。 |
|
感谢 PR！如果有兴趣一起参与维护 Umi，可加入我们的 Umi Contributor 群。加入方式是先用钉钉扫下方二维码加我钉钉，记得注明 github id，然后我会拉你到群里。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundler-webpack-demo 新增 todolist 页面