-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugin-request for umi 3 #22
Conversation
好像用例不全,没体现runtime里面的配置,还有中间件的影响。不过这部分不知道算不算在这里面。(又看了几遍,还是觉得少了啥!先不管吧) |
runtime 的有的,样例里面通过 mock 了不同的 runtime 配置。umi-request 中间件也有样例测试的。 |
ci 的问题 merge 下 master,之前的 yarn.lock 有问题。 |
1a0e7ee
to
e7f0b1e
Compare
ci 没过。 |
外部的包别用 ayarn,直接用 yarn 。 |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
===========================================
+ Coverage 33.61% 44.08% +10.46%
===========================================
Files 21 23 +2
Lines 351 431 +80
Branches 70 93 +23
===========================================
+ Hits 118 190 +72
- Misses 233 240 +7
- Partials 0 1 +1
Continue to review full report at Codecov.
|
@sorrycc CI 过了,把 mock 改为局部的手动 mock 了,这样就不会影响其它测试样例。 |
plugin-request 的样例都过了