Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin-request for umi 3 #22

Merged
merged 6 commits into from
Feb 12, 2020
Merged

feat: plugin-request for umi 3 #22

merged 6 commits into from
Feb 12, 2020

Conversation

yutingzhao1991
Copy link

plugin-request 的样例都过了

@xiaohuoni
Copy link
Member

xiaohuoni commented Feb 10, 2020

好像用例不全,没体现runtime里面的配置,还有中间件的影响。不过这部分不知道算不算在这里面。(又看了几遍,还是觉得少了啥!先不管吧)

@yutingzhao1991
Copy link
Author

好像用例不全,没体现runtime里面的配置,还有中间件的影响。不过这部分不知道算不算在这里面。

runtime 的有的,样例里面通过 mock 了不同的 runtime 配置。umi-request 中间件也有样例测试的。

package.json Outdated Show resolved Hide resolved
packages/plugin-request/package.json Outdated Show resolved Hide resolved
packages/plugin-request/src/index.ts Outdated Show resolved Hide resolved
@sorrycc
Copy link
Member

sorrycc commented Feb 10, 2020

ci 的问题 merge 下 master,之前的 yarn.lock 有问题。

@sorrycc
Copy link
Member

sorrycc commented Feb 10, 2020

ci 没过。

yarn.lock Outdated Show resolved Hide resolved
@sorrycc
Copy link
Member

sorrycc commented Feb 11, 2020

外部的包别用 ayarn,直接用 yarn 。

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #22 into master will increase coverage by 10.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   33.61%   44.08%   +10.46%     
===========================================
  Files          21       23        +2     
  Lines         351      431       +80     
  Branches       70       93       +23     
===========================================
+ Hits          118      190       +72     
- Misses        233      240        +7     
- Partials        0        1        +1     
Impacted Files Coverage Δ
packages/plugin-model/src/utils/index.ts 0.00% <0.00%> (ø) ⬆️
packages/plugin-request/src/index.ts 80.95% <0.00%> (ø)
packages/plugin-request/src/request.ts 93.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e4516...6608465. Read the comment docs.

@yutingzhao1991
Copy link
Author

@sorrycc CI 过了,把 mock 改为局部的手动 mock 了,这样就不会影响其它测试样例。

@sorrycc sorrycc merged commit 7ba0c52 into master Feb 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/plugin-request branch February 12, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants