Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dts lost when esm and cjs has different ignores #656

Merged
merged 2 commits into from
May 31, 2023

Conversation

PeachScript
Copy link
Member

修复 esm 和 cjs 有不同的 ignores 配置时,cjs 产物中部分 .d.ts 会丢失的问题

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (a800fe4) 93.66% compared to head (effa739) 93.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   93.66%   93.74%   +0.07%     
==========================================
  Files          55       55              
  Lines        1515     1518       +3     
  Branches      333      336       +3     
==========================================
+ Hits         1419     1423       +4     
+ Misses         96       95       -1     
Impacted Files Coverage Δ
src/builder/bundless/dts/index.ts 91.78% <100.00%> (+0.35%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PeachScript PeachScript merged commit 3ca7e38 into master May 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the hotfix/dts-lost-in-diff-bundless branch May 31, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant