This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 95.70% 94.97% -0.73%
==========================================
Files 43 45 +2
Lines 1071 1135 +64
Branches 236 266 +30
==========================================
+ Hits 1025 1078 +53
- Misses 45 56 +11
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PeachScript
reviewed
Aug 24, 2022
PeachScript
reviewed
Aug 26, 2022
src/commands/generators/jest.ts
Outdated
logger.info('Write jest-setup.ts'); | ||
} | ||
|
||
const collectCoverageFrom = hasSrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
father 没有 Umi 的约定式路由逻辑、不用判断 hasSrc
,部分值应该也用不到,可能这些就够了:
[
'src/**/*.{ts,js,tsx,jsx}',
]
如果 devDependencies
里存在 dumi,需要加上这几项:
[
'!src/.umi/**',
'!src/.umi-test/**',
'!src/.umi-production/**',
]
PeachScript
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
PeachScript
pushed a commit
to umijs/father
that referenced
this pull request
Aug 26, 2022
* feat: support generate jest * test: add generate jest test * refactor: adjust jest.config * chore: move to tests * feat: add dumi cov and remove umi cov
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
借鉴了下 umi 的实现