Skip to content

LIBDRUM-790. Updated "README-DRUM.md" for DSpace 7#211

Merged
dsteelma-umd merged 1 commit intoumd-lib:drum-mainfrom
dsteelma-umd:feature/LIBDRUM-790
May 12, 2023
Merged

LIBDRUM-790. Updated "README-DRUM.md" for DSpace 7#211
dsteelma-umd merged 1 commit intoumd-lib:drum-mainfrom
dsteelma-umd:feature/LIBDRUM-790

Conversation

@dsteelma-umd
Copy link

Updated the "README-DRUM.md" for DSpace 7:

  • Removed links to documents that are no longer included in the repository
  • Rewrote "Building Images for K8s Deployment" instructions to use Kubernetes "build" namespace. This is needed because "arm64"-based Apple laptops can not build the "amd64" images used by Kubernetes

https://umd-dit.atlassian.net/browse/LIBDRUM-790

References

Add references/links to any related issues or PRs. These may include:

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

@dsteelma-umd dsteelma-umd force-pushed the feature/LIBDRUM-790 branch 3 times, most recently from 98af475 to 1759b98 Compare May 12, 2023 12:09
Updated the "README-DRUM.md" for DSpace 7:

* Removed links to documents that are no longer included in the
  repository
* Rewrote "Building Images for K8s Deployment" instructions to use
  Kubernetes "build" namespace. This is needed because "arm64"-based
  Apple laptops can not build the "amd64" images used by Kubernetes

https://umd-dit.atlassian.net/browse/LIBDRUM-790
@dsteelma-umd dsteelma-umd force-pushed the feature/LIBDRUM-790 branch from 1759b98 to 091e5c7 Compare May 12, 2023 12:21
@dsteelma-umd dsteelma-umd merged commit 4e8cc0a into umd-lib:drum-main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant