Skip to content

LIBDRUM-668. Restored license and CheckStyle checks in CI jobs#210

Merged
dsteelma-umd merged 1 commit intoumd-lib:drum-mainfrom
dsteelma-umd:feature/LIBDRUM-668
May 11, 2023
Merged

LIBDRUM-668. Restored license and CheckStyle checks in CI jobs#210
dsteelma-umd merged 1 commit intoumd-lib:drum-mainfrom
dsteelma-umd:feature/LIBDRUM-668

Conversation

@dsteelma-umd
Copy link

The license violations that were previously being reported appear to have been fixed. CheckStyle warnings were fixed as part of LIBDRUM=667.

Modified the GitHub Action ".github/workflows/build.yml" file to restore running both the license and CheckStyle checks.

Modified the "Jenkinsfile" using by Jenkins to restore the license checks (CheckStyle checking had previously been restored).

https://umd-dit.atlassian.net/browse/LIBDRUM-668

References

Add references/links to any related issues or PRs. These may include:

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

The license violations that were previously being reported appear to
have been fixed. CheckStyle warnings were fixed as part of LIBDRUM=667.

Modified the GitHub Action ".github/workflows/build.yml" file to restore
running both the license and CheckStyle checks.

Modified the "Jenkinsfile" using by Jenkins to restore the license
checks (CheckStyle checking had previously been restored).

https://umd-dit.atlassian.net/browse/LIBDRUM-668
@dsteelma-umd dsteelma-umd merged commit 1157d6b into umd-lib:drum-main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant