Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vorto failed to convert db value when vorto does not have the DtdGuid #74

Closed
rasmuseeg opened this issue Dec 5, 2016 · 5 comments
Closed

Comments

@rasmuseeg
Copy link
Contributor

When setting propertyvalue to VortoValue with empty DtdGuid, getting vorto value from frontend breaks. Why is the DtdGuid even required, shouldn't vorto resolve this from the prevalue collection?

@mattbrailsford
Copy link
Collaborator

Because at some point in the code chain there is a point at which the property editor has no context when abiding by the public methods in Umbraco so we have to stash the GUID at a point we do know it so we can access it later on.

@mattbrailsford
Copy link
Collaborator

As mentioned, this is required due to an issue in the umbraco api points so is not a bug. If you are setting the VortoValue manually, you'll have to set the DtdGuid

@rasmuseeg
Copy link
Contributor Author

Wouldn't it make ideal fallback on Umbraco.Textarea or Umbraco.Textstring?

@mattbrailsford
Copy link
Collaborator

I'd need to think through the whole model and check the code that uses it to see if it would be a problem, unfortunately I'm really low on time atm so it's gonna be pretty low priority.

Feel free to test / PR if you like and I can review what you come up with.

@rasmuseeg
Copy link
Contributor Author

rasmuseeg commented Dec 5, 2016 via email

mattbrailsford added a commit that referenced this issue Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants