Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email check #34

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fix email check #34

merged 2 commits into from
Oct 28, 2024

Conversation

tycooon
Copy link
Member

@tycooon tycooon commented Oct 26, 2024

Короче емейл вида user@one.two42.com считался невалидным ¯\_(ツ)_/¯

@tycooon tycooon requested a review from KirIgor October 26, 2024 09:55
@coveralls
Copy link

coveralls commented Oct 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11530916737

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 69.499%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/umbrellio_utils/checks.rb 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
lib/umbrellio_utils/control.rb 1 18.6%
Totals Coverage Status
Change from base Build 11366102050: 0.2%
Covered Lines: 388
Relevant Lines: 521
💛 - Coveralls

alexander-baz
alexander-baz approved these changes Oct 28, 2024
View reviewed changes
Copy link

@alexander-baz alexander-baz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tycooon tycooon merged commit 6405165 into main Oct 28, 2024
4 checks passed
@tycooon tycooon deleted the fix-email-check branch October 28, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-baz alexander-baz alexander-baz approved these changes

@KirIgor KirIgor Awaiting requested review from KirIgor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tycooon @coveralls @alexander-baz