-
Notifications
You must be signed in to change notification settings - Fork 56
Add range with support for Lit 2 and Lit 3 #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
do not automatically import lit for esm, but instead defer it to the umd bundle
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-706.westeurope.azurestaticapps.net |
Changes
index.umd.ts
barrel to implicitly load Lit only for the UMD bundle of the UUI packageScreenshots
npm ls
on Umbraco.CMS.Backoffice:runtime on Vite's dev server for Umbraco.CMS.Backoffice:

Caveats
It works both with Lit 2 and Lit 3. With this change, you are responsible for installing a version of Lit using the ESM version of the UI library.
You will probably start seeing warnings like this when upgrading to Lit 3 on your downstream repositories:
We are not upgrading the UI library itself to Lit 3 with this change (Lit is bumped to only 2.8.0 in the main
package.json
file). Lit 2.8.0 is now the minimum required version to run the library.How to test
You can pack a few of the packages in the UI library locally and point Umbraco.CMS.Backoffice to the files locally:
You need to pack uui, uui-base and uui-css and override uui-css and uui-base with the local versions and then upgrade Lit to 3.1.1 and it should work.