Skip to content

fix: direct imports are not allowed #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: direct imports are not allowed #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/uui-card-media/lib/uui-card-media.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ import { css, html, nothing } from 'lit';
import { property, state } from 'lit/decorators.js';
import { ifDefined } from 'lit/directives/if-defined.js';

import '@umbraco-ui/uui-symbol-folder/lib';
import '@umbraco-ui/uui-symbol-file/lib';

/**
* @element uui-card-media
* @description - Card component for displaying a media item.
Expand Down
3 changes: 1 addition & 2 deletions packages/uui-combobox/lib/uui-combobox.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
UUIComboboxListEvent,
} from '@umbraco-ui/uui-combobox-list/lib';
import { iconRemove } from '@umbraco-ui/uui-icon-registry-essential/lib/svgs';
import type { UUIPopoverContainerElement } from '@umbraco-ui/uui-popover-container/lib';
import { css, html, LitElement } from 'lit';
import {
property,
Expand All @@ -16,8 +17,6 @@ import {

import { UUIComboboxEvent } from './UUIComboboxEvent';

import type { UUIPopoverContainerElement } from '@umbraco-ui/uui-popover-container/lib';

/**
* @element uui-combobox
* @fires {UUIComboboxEvent} input - fires when search input is changed
Expand Down
28 changes: 15 additions & 13 deletions packages/uui-tabs/lib/uui-tab-group.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
import { demandCustomElement } from '@umbraco-ui/uui-base/lib/utils';
import type { UUIButtonElement } from '@umbraco-ui/uui-button/lib';
import type { UUIPopoverContainerElement } from '@umbraco-ui/uui-popover-container/lib';
import { css, html, LitElement } from 'lit';
import { property, query, queryAssignedElements } from 'lit/decorators.js';
import { repeat } from 'lit/directives/repeat.js';

import type { UUIButtonElement } from '@umbraco-ui/uui-button/lib';
import '@umbraco-ui/uui-button/lib';
import '@umbraco-ui/uui-popover-container/lib';
import '@umbraco-ui/uui-symbol-more/lib';

import { UUITabElement } from './uui-tab.element';
import { UUIPopoverContainerElement } from '@umbraco-ui/uui-popover-container/lib';
import type { UUITabElement } from './uui-tab.element';

/**
* @element uui-tab-group
* @slot - Default slot for the tab group
* @element uui-tab-group
* @slot - Default slot for the tab group
* @cssprop --uui-tab-group-dropdown-tab-text - Define the tab text color in the dropdown
* @cssprop --uui-tab-group-dropdown-tab-text-hover - Define the tab text hover color in the dropdown
* @cssprop --uui-tab-group-dropdown-tab-text-active - Define the tab text active color in the dropdown
Expand Down Expand Up @@ -53,12 +50,15 @@ export class UUITabGroupElement extends LitElement {

#visibilityBreakpoints: number[] = [];

#resizeObserver: ResizeObserver = new ResizeObserver(
this.#onResize.bind(this)
);
#resizeObserver = new ResizeObserver(this.#onResize.bind(this));

connectedCallback() {
super.connectedCallback();

demandCustomElement(this, 'uui-button');
demandCustomElement(this, 'uui-popover-container');
demandCustomElement(this, 'uui-symbol-more');

this.#resizeObserver.observe(this);
if (!this.hasAttribute('role')) this.setAttribute('role', 'tablist');
}
Expand Down Expand Up @@ -205,7 +205,9 @@ export class UUITabGroupElement extends LitElement {
}

#isElementTabLike(el: any): el is UUITabElement {
return el instanceof UUITabElement || 'active' in el;
return (
typeof el === 'object' && 'active' in el && typeof el.active === 'boolean'
);
}

render() {
Expand Down