Skip to content

Feature/popover container firefox polyfill #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
5aa9229
open and close
JesmoDev Oct 26, 2023
416bc4d
deactivate focus listener
JesmoDev Oct 26, 2023
cf9bd1f
handle parent closing
JesmoDev Oct 26, 2023
159a72e
only move container to body when opened
JesmoDev Oct 26, 2023
37fe726
beforeToggleProxy
JesmoDev Oct 26, 2023
ba3d9b5
move polyfill to external function
JesmoDev Oct 27, 2023
a23ab54
cleanup
JesmoDev Oct 27, 2023
002a71d
fix eventlisteners not unsubscribing. and parent bug
JesmoDev Oct 27, 2023
a34fc74
add 9999 z-index
JesmoDev Oct 27, 2023
9e117dc
add focus dismiss
JesmoDev Oct 27, 2023
3238bc0
findAncestorByAttributeValue now looks at shadowroot hosts
JesmoDev Oct 27, 2023
52563cb
fix polyfill
JesmoDev Oct 27, 2023
7588629
ts
JesmoDev Oct 27, 2023
a7b3379
fix polyfill
JesmoDev Oct 27, 2023
fabcbb5
add test story
JesmoDev Oct 27, 2023
7adc83a
move container back to original dom position when closed
JesmoDev Nov 2, 2023
22aedb9
insert style tag to preserve styles from parent
JesmoDev Nov 2, 2023
faceadf
update test story
JesmoDev Nov 2, 2023
64c5143
add comment
JesmoDev Nov 2, 2023
8610412
test
JesmoDev Nov 2, 2023
769e721
Merge remote-tracking branch 'origin/v1/main' into feature/popover-co…
JesmoDev Nov 2, 2023
3115e85
fix styles
JesmoDev Nov 2, 2023
4f98b71
Merge remote-tracking branch 'origin/v1/contrib' into feature/popover…
JesmoDev Nov 2, 2023
48c89b6
test story
JesmoDev Nov 2, 2023
c9a3e19
prefix popover id to prevent css overwrites
JesmoDev Nov 2, 2023
961b379
remove unnecessary check
JesmoDev Nov 2, 2023
3a1ca32
cleanup
JesmoDev Nov 2, 2023
8eed4f8
Merge remote-tracking branch 'origin/v1/contrib' into feature/popover…
JesmoDev Nov 7, 2023
844d8c0
Merge remote-tracking branch 'origin/v1/contrib' into feature/popover…
JesmoDev Nov 7, 2023
1a60533
Merge remote-tracking branch 'origin/v1/contrib' into feature/popover…
JesmoDev Nov 8, 2023
f2bfaa3
deprecate popover
JesmoDev Nov 8, 2023
0469e50
comment
JesmoDev Nov 8, 2023
70dafa8
update docs
JesmoDev Nov 8, 2023
e72cd0e
remove test story
JesmoDev Nov 8, 2023
5be5e72
update docs
JesmoDev Nov 8, 2023
d071707
add tooltip example
JesmoDev Nov 8, 2023
6918543
note
JesmoDev Nov 8, 2023
ac83727
Merge remote-tracking branch 'origin/v1/contrib' into feature/popover…
JesmoDev Nov 8, 2023
d625144
add tooltip story
JesmoDev Nov 8, 2023
90bb328
cleanup
JesmoDev Nov 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deprecate popover
  • Loading branch information
JesmoDev committed Nov 8, 2023
commit f2bfaa3b50e93cb54e74cb2a8431819ea4210c7b
1 change: 1 addition & 0 deletions packages/uui-popover/lib/uui-popover.element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ function mathClamp(value: number, min: number, max: number) {
}

/**
* @deprecated
* @element uui-popover
* @description Open a modal aligned with the opening element. This does not jet work within two layers of scroll containers.
* @fires close - When popover is closed by user interaction.
Expand Down
20 changes: 20 additions & 0 deletions packages/uui-popover/lib/uui-popover.mdx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { Meta, Primary, Controls, Story } from '@storybook/blocks';
import * as stories from './uui-popover.story';

<Meta of={stories} />

# Popover Container

<div
style={{
borderLeft: '6px solid #f3d41b',
background: '#f3d41b24',
padding: '0px 16px',
display: 'flex',
}}>
Deprecated: This component has been deprecated and will be removed in future
releases. It is being replaced by.
**[popover-container](/docs/uui-popover-container--docs)**
</div>

<Controls />