-
Notifications
You must be signed in to change notification settings - Fork 53
Update story for color swatches #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update story for color swatches #488
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
@iOvergaard I don't see this story here? Also did the property change from in but not in story of |
@bjarnef it is still called "swatches". I needed to invent a new control for Storybook, which I named "swatchesColor" so it doesn't collide with the property of the component. If you check the docs, there is still the "swatches" property and the other one is just a control for Storybook, since we needed to have the data stored somewhere visible. The "value" field does not use the color picker, because it is the selected value, i.e. the output value of the component, and for purposes of experimenting with the 'value' property, we need to make sure you can type one of the existing colors into the field to have it selected, which would be very hard to "pick" using a color picker. Hope that makes sense. |
It seems the mapping pass in I guess the variable should be changes to
|
The |
… with example where label is different than value.
Description
Update the story of color swatches to use array of objects instead to show label can be different than value.
while string array still works.
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist