fix: not possible to drag&drop file with multiple dots #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and ensure that for file extensions, only the last entry after splitting "." is used
|
LGTM |
JesmoDev
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #485
It is not possible to drag & drop files containing multiple dots in their name when using an "accept" filter.
This PR aims to change the behavior so that first and foremost, we split file names by
.and then use the last dot and not the first.Secondly, we are now treating and dividing accept parameters in a setter on the property so that it is only done once, and we now also support receiving file extensions both with and without a
.in the accept property.Types of changes
How to test?
Checklist