Skip to content

feat: add missing native attributes to uui-input and uui-textarea #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2023

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented May 15, 2023

Description

  • uui-input now has pattern attribute

  • uui-input now has inputmode attribute

  • uui-input has a story with the pattern and inputmode set.

  • uui-textarea now has rows and cols attribute

  • uui-textarea now has wrap attribute

  • New feature (non-breaking change which adds functionality)

@loivsen loivsen requested a review from iOvergaard May 15, 2023 07:53
@iOvergaard iOvergaard changed the title Feature/pattern and other native attributes feat: add missing native attributes to uui-input and uui-textarea May 15, 2023
@iOvergaard iOvergaard added the enhancement New feature or request label May 15, 2023
loivsen and others added 2 commits May 15, 2023 10:49
Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard merged commit 93adc81 into v1/contrib May 15, 2023
@iOvergaard iOvergaard deleted the feature/pattern-and-other-native-attributes branch May 15, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants