Skip to content

fix: keydown events are prevented from bubbling in uui-table-cell #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2023
Merged

fix: keydown events are prevented from bubbling in uui-table-cell #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0a5a9e
fix: SelectableMixin should not prevent bubbling of keydown event
iOvergaard May 12, 2023
9e93f52
docs: update stories to test input fields in tables
iOvergaard May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/uui-base/lib/mixins/SelectableMixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export const SelectableMixin = <T extends Constructor<LitElement>>(
private handleSelectKeydown(e: KeyboardEvent) {
if (e.composedPath().indexOf(this.selectableTarget) !== -1) {
if (e.key !== ' ' && e.key !== 'Enter') return;
e.preventDefault();
this._toggleSelect();
}
}
Expand Down
26 changes: 19 additions & 7 deletions packages/uui-table/lib/uui-table-cell.story.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
import '.';

import { Story } from '@storybook/web-components';
import type { Meta, StoryFn } from '@storybook/web-components';
import { html } from 'lit';

import { UUITableCellElement } from './uui-table-cell.element';
import type { UUITableCellElement } from './uui-table-cell.element';

import '@umbraco-ui/uui-input/lib';
import './uui-table-cell.element';

export default {
const meta: Meta<typeof UUITableCellElement> = {
title: 'Layout/Table/Table Cell',
component: 'uui-table-cell',
id: 'uui-table-cell',
};

export const AAAOverview: Story<UUITableCellElement> = props =>
html`
export default meta;

const Template: StoryFn<UUITableCellElement> = props => {
return html`
<uui-table
aria-label="Random Umbraco Words"
aria-describedby="table-description">
Expand All @@ -29,6 +32,12 @@ export const AAAOverview: Story<UUITableCellElement> = props =>
?clip-text=${props.clipText}>
Rocks
</uui-table-cell>
<uui-table-cell
?disable-child-interaction=${props.disableChildInteraction}
?no-padding=${props.noPadding}
?clip-text=${props.clipText}>
<uui-input placeholder="Type your own thing"></uui-input>
</uui-table-cell>
<uui-table-cell
?disable-child-interaction=${props.disableChildInteraction}
?no-padding=${props.noPadding}
Expand All @@ -38,6 +47,9 @@ export const AAAOverview: Story<UUITableCellElement> = props =>
</uui-table-row>
</uui-table>
`;
};

export const AAAOverview = Template.bind({});
AAAOverview.storyName = 'Overview';
AAAOverview.args = {
slot: 'Very very very Very very very Very very very Very very very Very very very long sentence',
Expand Down
61 changes: 32 additions & 29 deletions packages/uui-table/lib/uui-table-row.story.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,45 @@
import '.';

import { Story } from '@storybook/web-components';
import { Meta, StoryFn } from '@storybook/web-components';
import { html } from 'lit';

import { ArrayOfUmbracoWords } from '../../../storyhelpers/UmbracoWordGenerator';
import type { UUITableRowElement } from './uui-table-row.element';

import '@umbraco-ui/uui-input/lib';
import './uui-table-row.element';

export default {
const meta: Meta<typeof UUITableRowElement> = {
title: 'Layout/Table/Table Row',
component: 'uui-table-row',
id: 'uui-table-row',
};

export const AAAOverview: Story = () =>
html`
<uui-table
aria-label="Random Umbraco Words"
aria-describedby="table-description">
<uui-table-row>
${ArrayOfUmbracoWords(3).map(
export default meta;

const Template: StoryFn<UUITableRowElement> = props => {
return html`
<uui-table>
<uui-table-row
?selectable=${props.selectable}
?selectOnly=${props.selectOnly}>
${ArrayOfUmbracoWords(5).map(
el => html`<uui-table-cell>${el}</uui-table-cell>`
)}
</uui-table-row>
<uui-table-row
?selectable=${props.selectable}
?selectOnly=${props.selectOnly}>
<uui-table-cell>
<uui-input placeholder="Type your own thing"></uui-input>
</uui-table-cell>
${ArrayOfUmbracoWords(5).map(
el => html`<uui-table-cell>${el}</uui-table-cell>`
)}
</uui-table-row>
</uui-table>
`;
};

export const AAAOverview = Template.bind({});
AAAOverview.storyName = 'Overview';

AAAOverview.parameters = {
Expand All @@ -43,24 +60,10 @@ AAAOverview.parameters = {
},
};

export const SelectableRows: Story = () =>
html`
<div style="width: 100%;">
<uui-table>
<uui-table-row selectable>
${ArrayOfUmbracoWords(5).map(
el => html`<uui-table-cell>${el}</uui-table-cell>`
)}
</uui-table-row>
<uui-table-row selectable>
${ArrayOfUmbracoWords(5).map(
el => html`<uui-table-cell>${el}</uui-table-cell>`
)}
</uui-table-row>
</uui-table>
</div>
`;

export const SelectableRows = Template.bind({});
SelectableRows.args = {
selectable: true,
};
SelectableRows.parameters = {
docs: {
source: {
Expand Down