Skip to content

build: add support for Node.js 18 #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2023
Merged

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented May 12, 2023

Description

Update all node modules to support Node 18 (LTS)

uui-css: fix custom postcss modules to handle custom properties fallback

fixes #442

How to test

Note
Remember to update your Node version for example by running nvm use and then reinstall node modules with npm install before testing

The CSS variables are converted into a typescript file which is then loaded dynamically through Storybook (amongst other things) and can be checked out through this link on Chromatic. We'll know this new code works if all variables are present there.

@iOvergaard iOvergaard changed the title feat: node 18 feat: add support for Node.js 18 May 12, 2023
@iOvergaard iOvergaard requested a review from nielslyngsoe May 12, 2023 12:02
@iOvergaard iOvergaard changed the title feat: add support for Node.js 18 chore: add support for Node.js 18 May 12, 2023
@iOvergaard iOvergaard added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code notable labels May 12, 2023
@iOvergaard iOvergaard changed the title chore: add support for Node.js 18 add support for Node.js 18 May 12, 2023
@iOvergaard iOvergaard enabled auto-merge (squash) May 12, 2023 12:04
@iOvergaard iOvergaard changed the title add support for Node.js 18 build: add support for Node.js 18 May 12, 2023
@iOvergaard iOvergaard disabled auto-merge May 12, 2023 12:57
@iOvergaard iOvergaard enabled auto-merge (squash) May 12, 2023 12:57
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iOvergaard iOvergaard merged commit ec5cd77 into v1/contrib May 15, 2023
@iOvergaard iOvergaard deleted the v1/feature/node-18 branch May 15, 2023 08:07
@iOvergaard iOvergaard removed dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update postcss-custom-properties from v12 to v13
2 participants