-
Notifications
You must be signed in to change notification settings - Fork 53
feat: change events to align with native browser behavior #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice this should go into a new Mayor version. Please create such a branch, there might be other things to join such a release.
Changing the Events Bubbles and Composed to match their equivalent browser native event.
Notice the change log of the events in file
docs/EVENTS.md
As well some events have been cancelable.
Description
Changes the UUIEvent to not bubble or composed, and makes it up to the individual specific event to set this them selfs.
Then each event has been changed to what makes sense in relation to Native Browser Events.
Types of changes
Motivation and context
We had to ensure we only have composed events when it makes sense. Otherwise, we would get unexpected events.
How to test?
Well, I'm not sure how to test this in the best way, but it should take part of a new Mayor version.
Screenshots (if appropriate)
Checklist