Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deselect hover indication should not appear when deselectable is false #564

Open
nielslyngsoe opened this issue Sep 1, 2023 · 0 comments
Labels
bug Something isn't working community/up-for-grabs needs triage This issue has not been tested by a team member yet

Comments

@nielslyngsoe
Copy link
Member

Which exact UI Library version are you using? For example: 1.0.1 - don't just write v1.

1.4.0-rc.1

Bug summary

When extending the uui-card element and setting selectable to true, but deselectable to false. I still see the indication on the border that a click will deselect the item. though it does not. We need to not have that CSS hover effect when deselectable is set to false.

image

Specifics

No response

Steps to reproduce

make a element that extends uui-card. like this:

`
@CustomElement('my-credit-card')
export class UmbCreditCardElement extends UUICardElement {

@property()
value?: string;

@property()
public get name(): string | undefined {
	return this._name;
}
public set name(name: string | undefined) {
	this._name = name;
	this.setAttribute('aria-label', name ?? '');
}
private _name?: string | undefined;

constructor() {
	super();
	this.selectable = true;
	this.deselectable = false;
	this.requestUpdate('selectable'); //temporary fix, cause by another issue fix in a PR.
}

public render() {
return html`<h5>${this.name}</h5>`;

}

static styles = [
	...UUICardElement.styles,
	css`
		:host {
			max-width: 240px;
		}
	`
];

}`

Expected result / actual result

No response

@nielslyngsoe nielslyngsoe added bug Something isn't working needs triage This issue has not been tested by a team member yet community/up-for-grabs labels Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community/up-for-grabs needs triage This issue has not been tested by a team member yet
Projects
None yet
Development

No branches or pull requests

1 participant