Bugfix: Use iife version of MSW #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How come this works under Vite but not web-dev-server? |
|
I am not sure what module resolution Vite runs all files through, but they are doing something magical. It is this bug mswjs/msw#1384 we are running into. Hopefully esm support will be possible one day. Until then it doesn't make a big difference. It is only code we use internally. |
madsrasmussen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The msw module version currently doesn't work in a browser. The means that we can not run mocks as part of the test runner. We will also run into the same problems when setting up import maps in web-dev-server as it is the same server as web-test-runner.