Review: Claude Skill for Review of Github PRs#22245
Review: Claude Skill for Review of Github PRs#22245nielslyngsoe wants to merge 43 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new internal Claude “review” skill for Umbraco CMS PR reviews, along with reference docs that guide impact analysis, breaking-change detection, and review criteria.
Changes:
- Introduces
.claude/skills/review/SKILL.mddefining an automated GH CLI-based PR review workflow. - Adds reference docs for impact analysis and breaking-change checks.
- Adds a “coding preferences & review criteria” reference used by the skill when scoring/reviewing changes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .claude/skills/review/SKILL.md | Defines the end-to-end workflow and output format for the automated PR review skill. |
| .claude/skills/review/references/impact-analysis.md | Documents how to assess ripple effects/consumers and check dependency direction. |
| .claude/skills/review/references/breaking-changes.md | Documents how to detect/mitigate breaking changes (C# + TS) using repo versioning policy. |
| .claude/skills/review/references/coding-preferences.md | Defines the scoring criteria and review standards the skill will apply. |
…loaded is the header
hifi-phil
left a comment
hifi-phil
left a comment
There was a problem hiding this comment.
This is a really good solid review skill. I think that the SKILL file should be broken, adding more reference file to keep it simpler. This will make it easier to understand and also easier to maintain.
| @@ -0,0 +1,324 @@ | |||
| --- | |||
There was a problem hiding this comment.
I think that this skill file is too long, I would split out into further reference files
There was a problem hiding this comment.
@hifi-phil Now its down to 225 lines. Is that maybe still too long?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added Claude Skill to review a Github PR. This requires the client to have the GH CLI and be authorized.
See example of review in this comment:
#22228 (comment)
Test Nodes
Run this Skill by typing
/reviewin the Claude terminalAIs own review of this skill