Skip to content

load more button component and styling #19622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2025

Conversation

nielslyngsoe
Copy link
Member

Implements a Tree Load More Button and restyles it to stand out clearly.

image

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 12:07
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduces a specialized tree “Load more” button component and replaces inline uui-button instances with it, plus adds styling and localization.

  • Swap out inline buttons for <umb-tree-load-more-button> in tree item and default tree components
  • Add umb-tree-load-more-button element, its styles, and export entry
  • Update localization files and core tree exports

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tree-item-base/tree-item-element-base.ts Replaced inline uui-button with custom load-more component
core/tree/index.ts Exported new components index
default/default-tree.element.ts Replaced inline uui-button with custom load-more component
components/tree-load-more-button.element.ts Added new load-more button component and styles
components/index.ts Export entry for the new component
assets/lang/en.ts Added loadMore translation
assets/lang/da.ts Added loadMore translation
Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/core/tree/components/tree-load-more-button.element.ts:1

  • [nitpick] No unit tests cover the new umb-tree-load-more-button component. Consider adding tests to verify rendering and click behavior.
import { css, customElement, html } from '@umbraco-cms/backoffice/external/lit';

src/Umbraco.Web.UI.Client/src/packages/core/tree/components/tree-load-more-button.element.ts:25

  • The CSS variable name has an extra dash (--uui-size---uui-size-layout-3), which likely does not match the intended --uui-size-layout-3. Please correct the variable name.
			height: var(--uui-size---uui-size-layout-3);

@madsrasmussen madsrasmussen merged commit c432f5a into main Jun 29, 2025
27 checks passed
@madsrasmussen madsrasmussen deleted the v16/feature/umb-load-more-button branch June 29, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants