Allow segment access to editors with access to documents, not only settings #19291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a permission error by allowing segment access for editors with "Document" permissions rather than exclusively "Settings" access. Key changes include adding an authorization policy for document access and removing the outdated settings access policy.
- Updated SegmentControllerBase to use TreeAccessDocuments policy.
- Removed settings-based authorization from AllSegmentController.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Cms.Api.Management/Controllers/Segment/SegmentControllerBase.cs | Added [Authorize(Policy = AuthorizationPolicies.TreeAccessDocuments)] to enforce document permissions. |
| src/Umbraco.Cms.Api.Management/Controllers/Segment/AllSegmentController.cs | Removed obsolete [Authorize(Policy = AuthorizationPolicies.SectionAccessSettings)] attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Noticed in a testing that with a user that didn't have access to "Settings" and with segments setup, you'd get a permissions error. This resolves it by asking only for "Document" section permissions.
Testing
Unless you already have segments set up for another reason, likely sufficient to visually inspect this one.
Release
No harm if this goes into 16.0-rc2, since it's a fix to an 16 specific issue.