Adjustment to obsolete methods in ContentValueSetValidator

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

Description

Related to #15135

I think https://github.com/umbraco/Umbraco-CMS/pull/14424/files marked it obsolete as the ctor is removed later and replaced by Infrastructure.Scoping.IScopeProvider and there isn't any easy way to convert/cast from Umbraco.Cms.Core.Scoping.IScopeProvider to Umbraco.Cms.Infrastructure.Scoping.IScopeProvider, so it introduce a breaking change in a major version instead.

[github-actions]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[georgebid]

And thank you for this one too! 💯 Someone will review this PR soon.

[emmagarland]

Hi @bjarnef

Sorry its been so long, before we look at this one is this still relevant in v14 now?

Thanks,

Emma

[bjarnef]

It seems to obsolete attribute was added in v14 here:
#14424

and removal in v16:
#18074