Skip to content

Conversation

@vsilvar
Copy link
Contributor

@vsilvar vsilvar commented Jul 12, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #10648

Description

Updated IUmbracoBuilder public extension methods to return the IUmbracoBuilder instance to allow for method chaining.

@vsilvar vsilvar changed the title #10648: Updated public IUmbracoBuilder extension methods to allow chaining Updated public IUmbracoBuilder extension methods to allow chaining Jul 12, 2021
@umbrabot
Copy link

umbrabot commented Jul 13, 2021

Hi there @vsilvar, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bergmania
Copy link
Member

Hi @vsilvar .. Thanks for contributing. I think the changes make sense, so i'll merge :)

@bergmania bergmania merged commit f9b91cd into umbraco:v9/dev Aug 4, 2021
@vsilvar vsilvar deleted the v9/feature/10648-umbracobuilder-extensions-chaining branch August 4, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants