Skip to content

Conversation

@Shazwazza
Copy link
Contributor

This updates to latest Smidge which is now on Nuget and updates how package assets are delivered when in debug mode. This is based off of some discussions like #10469

Disable composite files for package files when in debug mode. This means that the files will be delivered as-is without being processed but will contain the cache buster value. This is more like how v8 worked. This just makes it simpler for all package source debugging since you'll just be working with the raw files. I realize that the way it is now is not great for various reasons: Even if source maps worked, etc... the minify engine will remove debugging statements like debugger; or possibly even logging statements which is not good for debugging. I'm sure nuglify could be tweaked for debug scenarios but IMO it's not worth the effort. Lets just let devs use their raw files to debug with cache busting enabled and then in non-debug we'll process all package files like we did in v8. This will mean that package devs will still need to test their package in non-debug mode to make sure that the minification/composite processing doesn't have any issues. (this will still be much better than v8 since nuglify is a much smarter js/css processor).

Copy link
Member

@bergmania bergmania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@Shazwazza
Copy link
Contributor Author

I also just pushed a bump for latest Examine on Nuget. But that's just a version change. Do you want me to just merge it?

@bergmania
Copy link
Member

I also just pushed a bump for latest Examine on Nuget. But that's just a version change. Do you want me to just merge it?

Yeah, that's fine :)

@Shazwazza Shazwazza merged commit 8cf8fb4 into v9/9.0-beta004 Jun 21, 2021
@Shazwazza Shazwazza deleted the v9/task/smidge-update branch June 21, 2021 20:22
@Shazwazza
Copy link
Contributor Author

Cool, that's all merged into beta4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants