Skip to content

Conversation

@bergmania
Copy link
Member

Details

  • Replaces System.Drawing with ImageSharp, and thereby fix TODO.

Test

  • Go to the media section and upload files of different types.
  • The following formats are supported
    • GIF : GifDecoder
    • PNG : PngDecoder
    • BMP : BmpDecoder
    • JPEG : JpegDecoder
    • TGA : TgaDecoder

@warrenbuckley
Copy link
Contributor

Code changes look fine
Will need to test this out next :)

@warrenbuckley
Copy link
Contributor

All works as expected

@warrenbuckley warrenbuckley merged commit 0bdeda3 into v9/dev May 5, 2021
@warrenbuckley warrenbuckley deleted the v9/feature/replace-system-drawing-with-imagesharp branch May 5, 2021 13:57
@ronaldbarendse
Copy link
Contributor

While working on PR #10623, I noticed we're loading the complete image into memory (by doing Image.Load(stream)) to get the width/height. ImageSharp also has an Image.Identify(stream) method that is more efficient: https://docs.sixlabors.com/articles/imagesharp/imageformats.html#metadata-only-decoding.

The PR to update this is already done: #10964 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants