DI Issues with DocumentEventAuthorizer

[gmanrodt]

Which Umbraco version are you using?

v15.1.2

Bug summary

Copied from: https://forum.umbraco.com/t/di-issues-with-documenteventauthorizer/1814

We have Umbraco v15.1.2 running fine for a large project I am working on. When I try to upgrade Umbraco to v15.2+ or v15.3, I get the exception below, running the project. The issue is due to the introduction of DocumentEventAuthorizer as a singleton, which relies on IAuthorizationService which is scoped and not a singleton.

Specifics

System.AggregateException   HResult=0x80131500   
Message=Some services are not able to be constructed   Source=Microsoft.Extensions.DependencyInjection   StackTrace: 
   at Microsoft.Extensions.DependencyInjection.ServiceProvider..ctor(ICollection`1 serviceDescriptors, ServiceProviderOptions options)
    at Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(IServiceCollection services, ServiceProviderOptions options)
    at Microsoft.Extensions.Hosting.HostApplicationBuilder.Build()
    at Microsoft.AspNetCore.Builder.WebApplicationBuilder.Build() 
    at ClientProject.Program.<Main>d__0.MoveNext() in C:\projects\Clients\ClientProject.Web\Program.cs:line 23
    at ClientProject.Web.Program.<Main>(String[] args)

This exception was originally thrown at this call stack:
Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.VisitCallSite(Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.CallSiteValidatorState)     Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.VisitConstructor(Microsoft.Extensions.DependencyInjection.ServiceLookup.ConstructorCallSite, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.CallSiteValidatorState)     Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor<TArgument, TResult>.VisitCallSite(Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite, TArgument)     Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.VisitCallSite(Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteValidator.CallSiteValidatorState)     Microsoft.Extensions.DependencyInjection.ServiceProvider.ValidateService(Microsoft.Extensions.DependencyInjection.ServiceDescriptor)  Inner Exception 1: InvalidOperationException: Error while validating the service descriptor 'ServiceType: Umbraco.Cms.Api.Management.ServerEvents.Authorizers.DocumentEventAuthorizer Lifetime: Singleton ImplementationType: Umbraco.Cms.Api.Management.ServerEvents.Authorizers.DocumentEventAuthorizer': Cannot consume scoped service 'Microsoft.AspNetCore.Authorization.IAuthorizationService' from singleton 'Umbraco.Cms.Api.Management.ServerEvents.Authorizers.DocumentEventAuthorizer'.  Inner Exception 2: InvalidOperationException: Cannot consume scoped service 'Microsoft.AspNetCore.Authorization.IAuthorizationService' from singleton 'Umbraco.Cms.Api.Management.ServerEvents.Authorizers.DocumentEventAuthorizer'.

Steps to reproduce

Steps to reproduce: Modify the Startup.cs, adding the following:

var builder = WebApplication.CreateBuilder(args);  
builder.Host.UseDefaultServiceProvider(
      (context, options) =>
      {
          options.ValidateOnBuild = true;
          options.ValidateScopes = true;
      }); 

Alternatively, set "ASPNETCORE_ENVIRONMENT": "Development" in the launchSettings.json.

Expected result / actual result

No response

[github-actions]

Hi there @gmanrodt!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[umbracocommunity]

This issue has been mentioned on Umbraco community forum. There might be relevant details there:

https://forum.umbraco.com/t/di-issues-with-documenteventauthorizer/1814/3

[AndyButland]

Thanks for reporting @gmanrodt, however I'm not able to replicate this from a clean install. Could you review what I'm doing and let me know if you see something I'm missing in the testing steps please?

dotnet new install Umbraco.Templates::15.3.1
dotnet new umbraco --name TestProject
cd .\TestProject\
code .

Added the following lines to Program.cs, on line 2 just after the existing: WebApplicationBuilder builder = WebApplication.CreateBuilder(args);:

builder.Host.UseDefaultServiceProvider(
      (context, options) =>
      {
          options.ValidateOnBuild = true;
          options.ValidateScopes = true;
      });

dotnet build
dotnet run

Umbraco build and runs without issues.

[gmanrodt]

Hm. I was able to reproduce it consistently (every run) when I posted this, but am unable to now with v15.3.1. Unfortunately, we still see this issue with our main project, despite it also being on v15.3.1... I am going to strip down our main project, and see if I can pinpoint the issue.

[ane-dwarf]

EDIT: Umbraco version 15.4.0

Hope I'm not derailing to much here but I had the same issue. We implemented a policy:

builder.Services.AddSingleton<IAuthorizationHandler, GroupAuthorizationHandler>();

builder.Services.AddAuthorization(options =>
{
    options.AddPolicy(Policies.Admin,
        policy =>
        {
            policy.AddRequirements(new IsUserInGroupRequirement(new[]
                { Policies.Admin.ToCamelCase() }));
        });
});

Originally it was Scoped causing the same error as @gmanrodt explains. Looking at the Microsoft documentation for policy based authorization (https://learn.microsoft.com/en-us/aspnet/core/security/authorization/policies?view=aspnetcore-9.0) once again I changed it to Singleton. This removes the original error but now we get this:

InvalidOperationException: Error while validating the service descriptor 'ServiceType: Microsoft.AspNetCore.Authorization.IAuthorizationService Lifetime: Transient ImplementationType: Microsoft.AspNetCore.Authorization.DefaultAuthorizationService': Cannot consume scoped service 'Umbraco.Cms.Core.Security.IBackOfficeUserManager' from singleton 'Microsoft.AspNetCore.Authorization.IAuthorizationHandler'.

Because we're using DI on the GroupAuthorizationHandler.

public class GroupAuthorizationHandler : AuthorizationHandler<IsUserInGroupRequirement>
{
    private readonly IUserService _userService;
    private readonly IBackOfficeUserManager _backOfficeUserManager;

    public GroupAuthorizationHandler(IUserService userService, IBackOfficeUserManager backOfficeUserManager)
    {
        _userService = userService;
        _backOfficeUserManager = backOfficeUserManager;
    }
}

I decided to go with the not so elegant approach by using GetService from ServiceProvider in HttpContext and only injecting the IUserService.
Would be nice with some inputs for a more nice solution though and I also hope that this might help anyone else who's also experiencing this.

protected override async Task HandleRequirementAsync(AuthorizationHandlerContext context,
    IsUserInGroupRequirement requirement)
{
    if (context.Resource is HttpContext httpContext)
    {
        if (httpContext.RequestServices.GetService(typeof(IBackOfficeUserManager)) is not IBackOfficeUserManager
            backOfficeUserManager)
        {
            await Fail($"Could not resolve type: {nameof(IBackOfficeUserManager)}", httpContext, context);
            return;
        }
    }
}