fix: allow to save a remote data with unloaded data #2657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading remote data fails, the layer is in state "unloaded", and thus it was not possible to save it. This "isLoaded" check is made for non remote layer so that we don't save it by mistake with no data. Also, let's allow to edit non loaded layers, this check was there when settings was not on db, so not all loaded at map init, again not to override with incomplete metadata.
davidbgk
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading remote data fails, the layer is in state "unloaded", and thus it was not possible to save it.
This "isLoaded" check is made for non remote layer so that we don't save it by mistake with no data.
Also, let's allow to edit non loaded layers, this check was there when settings was not on db, so not all loaded at map init, again not to override with incomplete metadata.