Update build.gradle #837
Merged
Update build.gradle #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullPointeRR
approved these changes
Jun 18, 2017
tokudu
reviewed
Jun 19, 2017
library/build.gradle
Outdated
| compile 'com.android.support:recyclerview-v7:23.4.0' | ||
| compile 'com.android.support:support-v4:26.+' | ||
| compile 'com.android.support:support-annotations:26.+' | ||
| compile 'com.android.support:recyclerview-v7:26.+' |
There was a problem hiding this comment.
can you update to use the exact version without "+" and I'd be happy to merge this
There was a problem hiding this comment.
Oh yes of course
I have updated the 26.+ to the correct version. And yes the Gradle version also has to be upgraded in the file AndroidSlidingUpPanel/build.gradle Line no 8 to -> classpath 'com.android.tools.build:gradle:2.3.2' and Line no 26 to -> gradleVersion = '3.3'
tokudu
reviewed
Sep 14, 2017
| compile 'com.android.support:support-v4:23.4.0' | ||
| compile 'com.android.support:support-annotations:23.4.0' | ||
| compile 'com.android.support:recyclerview-v7:23.4.0' | ||
| compile 'com.android.support:support-v4:26.0.0-alpha1' |
There was a problem hiding this comment.
I prefer to avoid alpha libraries. If you change this to a stable version like 25, i'll merge. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google has updated its libraries