do not truncate usernames by word boundaries, instead truncate by grapheme - #651
Open
kaizoplant wants to merge 1 commit into
Open
do not truncate usernames by word boundaries, instead truncate by grapheme#651kaizoplant wants to merge 1 commit into
kaizoplant wants to merge 1 commit into
Conversation
Contributor
|
I believe the |
Contributor
Author
|
It doesn't seem to show up on the flamegraph for me so I imagine it shouldn't be too much of a problem. Also previously, it was still calling into split_word_bound_indices which I imagine was a bit worse for long usernames and display names (especially display names given it'd have to call split_word_bound_indices and then grapheme_indices after it failed), maybe it's better if it calls into something else entirely but it doesn't seem like too much of an issue rn? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, usernames truncated by user_gutter_width with word boundaries, such as display names like [somelongtexthere] or more relevant, usernames like @username:some.domain would be completely cut off after the first character. This pr makes it so that these will always just use the grapheme calculation directly.
Maybe this should be a config option? Although I do think it is usually preferable to have the username as visible as possible, it might still be useful to not always have this behavior.