-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the configuration to deploy yolov5 in in app engine #964
Conversation
…ngine on google cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Guilhen, thank you for submitting a PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- Verify your PR is up-to-date with origin/master. If your PR is behind origin/master update by running the following, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
- Verify all Continuous Integration (CI) checks are passing.
- Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
This is interesting. Can you explain the use case a bit and how we could integrate with google cloud app engine? Is there a free tier available that can run YOLOv5s? |
Hi Glenn, Here are a few use cases that I can think off:
To solve the problem, a python microservice can be deployed in the app engine Here is a link to try the app engine for free |
@Guilhen thanks for the explanation and the rebase! I think this would be good to merge. Would you be able to move the app_engine_config/ directory into the utils/ directory, and perhaps rename it google_app_engine/ in order to make it clearer? My other concern is the duplication of requirement packages already listed in the main requirements.txt, which will make maintenance more complicated. We already have different requirements for different use cases in practice, such as coremltools and onnx which are only required for export, but this is not well handled at the moment (optional packages are commented in requirements.txt). I'm thinking we may need to make a transition to a requirements/ directory such as https://github.com/PyTorchLightning/pytorch-lightning/tree/master/requirements with requirements/base.txt, requirements/export.txt, etc., which would then allow this PR to strip the requirements down to only the additional ones required for app engine. What do you think? |
Hi Glenn, |
@Guilhen great! Thanks for the changes, everything looks good. |
…cs#964) * add the configuration to deploy yolov5 in a docker container in app engine on google cloud * remove the duplicated requirements, place the google app engine files in utils * remove the unused requirements Co-authored-by: guilhembau <guilhem@6dbytes.com>
…cs#964) * add the configuration to deploy yolov5 in a docker container in app engine on google cloud * remove the duplicated requirements, place the google app engine files in utils * remove the unused requirements Co-authored-by: guilhembau <guilhem@6dbytes.com>
…cs#964) * add the configuration to deploy yolov5 in a docker container in app engine on google cloud * remove the duplicated requirements, place the google app engine files in utils * remove the unused requirements Co-authored-by: guilhembau <guilhem@6dbytes.com>
Here is the configuration to deploy yolov5 in the app engine in google cloud in a docker container.
The Nvidia container provided has some integration issues with the app engine.
The one provided works well
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Introduction of Google App Engine support for YOLOv5.
📊 Key Changes
Dockerfile
for Google App Engine (GAE) environment setup.additional_requirements.txt
for GAE-specific Python packages.app.yaml
configuration file for GAE deployment settings.🎯 Purpose & Impact