-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dataset names
from array to dictionary
#9000
Conversation
Just to confirm, this will be backwards compatible right? |
@AyushExel yeah that's the idea. All data yamls pass through check_dataset(), so I'll add some logic to check for |
names
from array to dictionary
names
from array to dictionarynames
from array to dictionary
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@AyushExel @kalenmike PR is merged, backwards compatible with older data yamls and should output the same results for HUB dataset stats. Let me know if you run into any problems. |
FYI @glenn-jocher this doesn't break loading/training, but because of the change at https://github.com/ultralytics/yolov5/pull/9000/files#diff-cfb1ff087a99a34369673c9f34bdcd22f2d429ab3599a89f386c5de1fd9a2566R452 (which sets |
* Migrate dataset names to dictionary * fix check * backwards compat * predict fix * val fix * Keep dataset stats behavior identical Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com> Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@austin1howard thanks for bringing this to our attention. I've made a note to check for this scenario and will make sure to address it in the next update. We aim to maintain compatibility and apologize for any inconvenience caused. |
Created with
@AyushExel @kalenmike implements names dict in yamls as discussed.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Refinement of class representation and minor code adjustments in Ultralytics YOLOv5.
📊 Key Changes
predict.py
to convert tensor to list when logging.🎯 Purpose & Impact
These changes create a more intuitive way of handling class names and data, positively impacting maintainability and scalability of the model configurations.