-
-
Notifications
You must be signed in to change notification settings - Fork 16.9k
Fix iterrows unpacking in export_formats for benchmark export #IEEESOC #13601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix iterrows unpacking in export_formats for benchmark export #IEEESOC #13601
Conversation
I have read the CLA Document and I sign the CLA 1 out of 2 committers have signed the CLA. |
👋 Hello @dorkdiaries9, thank you for submitting a To ensure a seamless integration of your update, please review the following checklist:
If your PR addresses a bug, please provide a minimum reproducible example (MRE) if you haven’t already. This helps us verify and resolve issues faster. For more details, check out our Contributing Guide. If you have any questions, feel free to leave a comment. Thank you for contributing to Ultralytics! 🚀🛠️ |
@dorkdiaries9 thank you! Please sign the CLA by writing a new comment like this: I have read the CLA Document and I sign the CLA |
I have read the CLA Document and I sign the CLA |
What does this PR do?
Fixes a bug in benchmarks.py where
export.export_formats().iterrows()
was incorrectly unpacked as:for i, (name, f, suffix, cpu, gpu) in export.export_formats().iterrows():
This caused a runtime error since iterrows() returns (index, Series), which is not directly unpackable like that.
✅ Replaced with:
This prevents unpacking errors during benchmark export.
I have read the CLA document and I sign the CLA.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved how export format details are accessed in the benchmarking script for better code clarity and reliability. 🛠️
📊 Key Changes
row["name"]
).🎯 Purpose & Impact