Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share button #23

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

john-rocky
Copy link
Contributor

@john-rocky john-rocky commented May 28, 2024

Fixed the share button functionality.
You can now share screenshots including camera footage.
With the existing code, the camera image part of the screenshot taken with the share button will be white. This is because AVPreviewLayer cannot be rendered as is.
The app was able to display the camera image by temporarily setting the camera image in imageview and inserting the imageview layer into videoPreview.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced photo sharing and capturing functionality in the YOLO iOS app. 📸✨

📊 Key Changes

  • Simplified photo sharing: The process to share a photo has been streamlined by directly capturing photos using AVCapturePhotoSettings and the app's existing camera output, removing previous complex steps.
  • Improved image processing: Added steps to display the captured image with the correct aspect ratio and orientation, then removing the temporary display layer once the image is ready to share.
  • Code cleanup: Removed unused lines of code and comments related to the old method of taking screenshots and saving images, making the codebase cleaner and more maintainable.

🎯 Purpose & Impact

  • Faster sharing: Users can now share photos faster and more efficiently, directly from their live camera feed, enhancing the overall user experience. 🚀
  • Higher quality images: The updates ensure images are captured and shared with the correct orientation and aspect ratio, improving the visual quality of shared content. 🖼️
  • Cleaner code: The changes contribute to a cleaner codebase, which is easier for developers to navigate and modify in the future. 👨‍💻👩‍💻

@glenn-jocher
Copy link
Member

@john-rocky wow nice work!!

@glenn-jocher glenn-jocher merged commit d9aa8ee into ultralytics:main May 29, 2024
2 checks passed
@glenn-jocher glenn-jocher mentioned this pull request May 29, 2024
john-rocky added a commit that referenced this pull request Jan 26, 2025
Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants