Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .github/workflows/ci.yml #236

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Delete .github/workflows/ci.yml #236

merged 1 commit into from
Dec 26, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Dec 26, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Removed the Continuous Integration (CI) workflow configuration file from the repository.

πŸ“Š Key Changes

  • Deleted the .github/workflows/ci.yml file, which was responsible for automating builds, tests, and documentation checks using GitHub Actions.
  • Removed tasks such as:
    • Building and verifying documentation.
    • Running Python tests (pytest) with test data downloads.
    • Slack notifications for workflow failures.

🎯 Purpose & Impact

  • Purpose: Simplify or rework the repository's CI/CD approach, potentially moving to a new CI system or removing unused workflows for cleanup.
  • Impact:
    • No automated tests, builds, or notifications will run until a replacement process is added (if intended).
    • Developers may need to execute tests and documentation checks manually or rely on external tools for CI tasks.
    • Reduces complexity in the short term but could hinder development flow if no alternative CI pipeline exists.

πŸ”§ This cleanup suggests possible restructuring or deprecation of certain CI-related activities in the project.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops documentation Improvements or additions to documentation labels Dec 26, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/hub-sdk πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/hub-sdk main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed the Contributor License Agreement (CLA) if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

Don’t hesitate to leave a comment if you have any questions. An Ultralytics engineer will review your contribution soon. Thank you for contributing to Ultralytics! πŸš€

@glenn-jocher glenn-jocher merged commit e5174fc into main Dec 26, 2024
4 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch December 26, 2024 13:06
@UltralyticsAssistant
Copy link
Member

πŸŽ‰ Woohoo! The PR is officially mergedβ€”great work, @glenn-jocher! Your thoughtful cleanup of the CI workflow marks a meaningful step toward simplifying and evolving our repository. 🌟

As Leonardo da Vinci once said, "Simplicity is the ultimate sophistication." This effort clears the path for new possibilities while reminding us of the power of thoughtful design. Thank you for your dedication to making things better, one PR at a time! πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants