Adding New Cycles feature in pomodoro.py file#2313
Adding New Cycles feature in pomodoro.py file#2313Pramod111666 wants to merge 5 commits intoultrabug:masterfrom
Conversation
|
Just checking , if there’s any changes needed from my side on this PR. Please let me know your feedback/ suggesstions on this PR. |
|
Thank you Pramod for your nicely written PR. I've let the CI run first so you get indications of what's needed to be fixed. I'll do my best to review it once CI is green ✔️ |
|
Problem-: CI failed due to docstring alphabetical ordering under tests directory. It has been fixed and tested. Fixed-: 4923d99 Request you to run the CI. jfyi-: config used has been attached as pdf. Thank you. |
|
Hi, My changes are limited to py3status/modules/pomodoro.py, which passes both tests and formatting locally. As I ran the full CI suite locally using hatch run all. All tests pass successfully. Please let me know if you would like me to include formatting fixes for unrelated files in a separate PR. The CI failure is from style:check (isort/black) and reports formatting issues in the following existing files (not related to my changes in pomodoro.py) py3status/modules/dnf_updates.py Please let me know if you would like me to include formatting fixes for unrelated files in a separate PR. Thank you. |
|
FWIW, I didn't review your PR because I already tried to add this in #1313 |
|
Thanks for the context — I see that the pomodoro module has been around since 2018. This PR doesn’t reintroduce or change the existing behavior. It only adds an optional cycles feature on top of the current logic. This cycles in pomodoro is intended purely as an additive feature |
|
@Pramod111666 thanks to @lasers we now have a clean CI. I'd appreciate you rebase to get a green CI PR before we invest time into reviewing your code please? |
4923d99 to
287343f
Compare
|
Hi @ultrabug — I’ve rebased and pushed the updates. CI is green locally. |
|
Hi @ultrabug Could you please approve the CI run? Once it shows green, I look forward to your review of the code. just for the context-: I’ve rebased and pushed the updates. CI is green locally. Thanks :) |
Summary
This PR adds an optional
cyclesconfiguration to thepomodoromodule, allowing users to group multiple pomodoro sessions into higher-level cycles.Existing users who do not configure
cyclessee no change and module behaves exactly as before.This PR introduces an optional
cyclesparameter to support that use case without altering existing behavior.Testing and resutls snapshot-: Attached as a pdf document.
About the changes done-:
What’s included
cyclesparameter (Noneby default){CycleNumber}) for display formatsBehavior overview
cyclessee no changeNote-:
Any feedback and suggestions are welcomed.
config_n_testing_resutls_pomodoro_cycles.pdf