Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update binrw and support more sections #13

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

ScanMountGoat
Copy link
Member

This uses the latest binrw version for reading. I tried to switch BinWrite to use binrw, but that caused some regressions in file writing for some reason.

@ScanMountGoat
Copy link
Member Author

ScanMountGoat commented Aug 28, 2022

This fixes #4 and #8

@ScanMountGoat ScanMountGoat changed the title use latest binrw from crates.io update binrw and support more sections Aug 28, 2022
@ScanMountGoat
Copy link
Member Author

BinWrite from binrw is working now. I just needed to change align_after to pad_size_to.

@jam1garner jam1garner merged commit 643859c into ultimate-research:master Aug 29, 2022
@jam1garner
Copy link
Member

Awesome stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants