Skip to content

#45 Verify if the username is an e-mail and avoid big usernames #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henriquejsfj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#45 Verify if the username is an e-mail and avoid big usernames #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions classes/BadpwFailedLoginsDAO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

use PKP\db\DAO;
use APP\plugins\generic\betterPassword\classes\BadpwFailedLogins as BadpwFailedLogins;
use APP\facades\Repo;

class BadpwFailedLoginsDAO extends DAO {
/**
Expand Down Expand Up @@ -58,6 +59,17 @@ public function deleteObject(BadpwFailedLogins $badpwObj) : bool {
* @return BadpwFailedLogins object Object matching the username
*/
public function getByUsername(string $username) : ?BadpwFailedLogins {
// Verify if the username is an email
if (filter_var($username, FILTER_VALIDATE_EMAIL)) {
$user = Repo::user()->getByEmail($username);
if (!$user) {
return null;
}
$username = $user->getData('userName');
} elseif (strlen($username) > 32) { // Invalid username length
return null;
}

$result = $this->retrieve('
SELECT *
FROM badpw_failedlogins
Expand Down