fix compilation error not detected during lint

.circleci/config.yml

@@ -23,7 +23,7 @@ jobs:
 
       - run:
           name: tslint
-          command: mkdir reports reports/junit; npm run tslint-ci
+          command: mkdir reports reports/junit; npm run tslint:ci
 
       - run:
           name: build

.travis.yml

@@ -13,6 +13,7 @@ install:
 
 script:
   - npm run clean
+  - npm run tslint:ci
   - npm run buildWebpack
   - npm run test
 

package.json

@@ -18,8 +18,8 @@
         "metagen": "node ./tests/meta/meta-generator \"./src/components\" \"./dist/components\" && node ./tests/meta/meta-generator \"./src/mixins\" \"./dist/mixins\"",
         "metagenv2": "node -r ./tests/meta-v2/ts-loader.js  ./tests/meta-v2/generate-meta.ts ./dist",
         "test": "jest --ci -w 1 --silent --coverage --testResultsProcessor=./tests/jest/ci-test-processor && jest -w 1 --ci --silent --config ./conf/storybook/jest.config.storybook.js --verbose",
-        "tslint": "tslint --project tsconfig.json -s node_modules/custom-tslint-formatters/formatters -t grouped",
-        "tslint-ci": "tslint --project tsconfig.json -t junit -o reports/junit/js-lint-results.xml ",
+        "tslint": "tsc --noEmit && tslint --project tsconfig.json -s node_modules/custom-tslint-formatters/formatters -t grouped ",
+        "tslint:ci": "tsc --noEmit && tslint --project tsconfig.json -t junit -o reports/junit/js-lint-results.xml ",
         "prepack": "npm run clean && npm run build && npm run buildlib",
         "component": "node ./tests/meta/component-generator",
         "stats": "webpack --config conf/webpack.config.js --env.lib --env.silent --colors --profile --json > reports/stats.json && webpack-bundle-analyzer reports/stats.json",
@@ -114,7 +114,7 @@
         "ts-loader": "^5.3.3",
         "ts-morph": "^1.0.0",
         "ts-node": "^7.0.1",
-        "tslint": "^5.12.0",
+        "tslint": "^5.14.0",
         "tslint-config-standard": "^8.0.1",
         "typescript": "^3.2.2",
         "typescript-tslint-plugin": "^0.3.0",

src/utils/file/file.spec.ts

@@ -289,7 +289,7 @@ describe('FileService', () => {
         const mockHttpService: () => jest.Mocked<HttpService> = () => {
             httpSvcMock = new HttpService() as jest.Mocked<HttpService>;
             (Vue.prototype as ModulVue).$http = httpSvcMock;
-            httpSvcMock.execute.mockReturnValue(Promise.resolve());
+            httpSvcMock.execute.mockReturnValue(Promise.resolve() as any);
 
             return httpSvcMock;
         };
@@ -332,7 +332,7 @@ describe('FileService', () => {
 
             it('should set the file status as failed when an error is encountered', async () => {
                 httpSvcMock.execute.mockReturnValue(
-                    Promise.reject('network error')
+                    Promise.reject('network error') as any
                 );
 
                 try {
@@ -349,9 +349,9 @@ describe('FileService', () => {
                     url: 'http://fake'
                 });
 
-                let axiosOptions: AxiosRequestConfig;
+                let axiosOptions: AxiosRequestConfig | undefined;
                 axiosOptions = httpSvcMock.execute.mock.calls[0][1];
-                axiosOptions.onUploadProgress!({
+                axiosOptions!.onUploadProgress!({
                     loaded: 10,
                     total: 200
                 });
@@ -367,9 +367,9 @@ describe('FileService', () => {
                     onUploadProgress: () => (customUploadProgressCalled = true)
                 });
 
-                let axiosOptions: AxiosRequestConfig;
+                let axiosOptions: AxiosRequestConfig | undefined;
                 axiosOptions = httpSvcMock.execute.mock.calls[0][1];
-                axiosOptions.onUploadProgress!({
+                axiosOptions!.onUploadProgress!({
                     loaded: 10,
                     total: 200
                 });
@@ -403,9 +403,9 @@ describe('FileService', () => {
                     url: 'http://fake'
                 });
 
-                let axiosOptions: AxiosRequestConfig;
+                let axiosOptions: AxiosRequestConfig | undefined;
                 axiosOptions = httpSvcMock.execute.mock.calls[0][1];
-                expect(axiosOptions.cancelToken).not.toBeUndefined();
+                expect(axiosOptions!.cancelToken).not.toBeUndefined();
             });
 
             it('should cancel the request using token', () => {
@@ -422,7 +422,7 @@ describe('FileService', () => {
                 httpSvcMock.execute.mockReturnValue(
                     Promise.reject({
                         __CANCEL__: true
-                    })
+                    }) as any
                 );
 
                 await filesvc.upload(fileToUpload.uid, {

tsconfig.json

@@ -27,6 +27,8 @@
         ]
     },
     "exclude": [
+        "node_modules",
+        "dist",
         "tests/meta/**.*",
         "conf/**"
     ]