Pass exif data to image scaling call.

This allows the loadImage library to apply the correct orientation based on Exif data and the given orientation option.
ukeenan · Jun 9, 2020 · 216d3c6 · 216d3c6
1 parent bc071fa
commit 216d3c6
Showing 1 changed file with 13 additions and 21 deletions.
diff --git a/js/jquery.fileupload-image.js b/js/jquery.fileupload-image.js
@@ -215,31 +215,23 @@
           },
           thumbnail,
           thumbnailBlob;
-        if (data.exif) {
-          if (options.orientation === true) {
+        if (data.exif && options.thumbnail) {
+          thumbnail = data.exif.get('Thumbnail');
+          thumbnailBlob = thumbnail && thumbnail.get('Blob');
+          if (thumbnailBlob) {
             options.orientation = data.exif.get('Orientation');
+            loadImage(thumbnailBlob, resolve, options);
+            return dfd.promise();
           }
-          if (options.thumbnail) {
-            thumbnail = data.exif.get('Thumbnail');
-            thumbnailBlob = thumbnail && thumbnail.get('Blob');
-            if (thumbnailBlob) {
-              loadImage(thumbnailBlob, resolve, options);
-              return dfd.promise();
-            }
-          }
-          // Prevent orienting browser oriented images:
-          if (loadImage.orientation) {
-            data.orientation = data.orientation || options.orientation;
-          }
+        }
+        if (data.orientation) {
           // Prevent orienting the same image twice:
-          if (data.orientation) {
-            delete options.orientation;
-          } else {
-            data.orientation = options.orientation;
-          }
+          delete options.orientation;
+        } else {
+          data.orientation = options.orientation;
         }
         if (img) {
-          resolve(loadImage.scale(img, options));
+          resolve(loadImage.scale(img, options, data));
           return dfd.promise();
         }
         return data;
@@ -319,7 +311,7 @@
           file = data.files[data.index],
           // eslint-disable-next-line new-cap
           dfd = $.Deferred();
-        if (data.orientation && data.exifOffsets) {
+        if (data.orientation === true && data.exifOffsets) {
           // Reset Exif Orientation data:
           loadImage.writeExifData(data.imageHead, data, 'Orientation', 1);
         }