-
Notifications
You must be signed in to change notification settings - Fork 11
🔧 Standardize CMake install destinations and library naming (shared support, MSVC exports, python setup consistency) #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The build result, which was executed for the conda-forge repo, might help clarify which artifacts will be distributed. |
|
Hi. Thanks for your changes. Please could you rebase these onto 'develop' and reopen the PR from there? |
…brary destinations
… '_static' suffix for clarity
…' suffix for consistency
…in the libraries list
f5f52ff to
598fb47
Compare
|
@jholloc Thank you for your comment! |
That was probably caused by the fact that I changed to use UDA shared libraries, rather than static libraries, in |
…c and shared UDA libraries
|
We reran the CI but the ubuntu build is still failing with the following error during pyuda build
|
|
@adam-parker1 Thank you for your suggestion! |
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 6. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…lop/actions/download-artifact-6 Bump actions/download-artifact from 4 to 6
* fixing multiple-read failures in getBytes plugin * fixing typo in pyuda get_file method
1afc2d7 to
6ca6c8a
Compare


Summary
To improve build/install consistency and simplify packaging, this change clarifies install destinations (
RUNTIME/LIBRARY/ARCHIVE) across CMakeLists and unifies the layout usingCMAKE_INSTALL_BINDIRandCMAKE_INSTALL_LIBDIR.It also normalizes library output names (especially for static libraries) and aligns them with the Python wrappers (both
setup.py.inandwin.setup.py.in).Shared library output is added or clarified for selected components, and MSVC export behavior is configured for Windows builds.
Key changes
install(TARGETS ...)destinations across CMakeLists:RUNTIME->CMAKE_INSTALL_BINDIR,LIBRARY/ARCHIVE->CMAKE_INSTALL_LIBDIR_staticsuffix for static libraries to avoid ambiguity against import libraries..lib) namingbindirsetup.py.inandwin.setup.py.in; simplify linking by collectinguda_libsintolibrariesCMake
install(TARGETS ...)and output typeRUNTIME.exe,.dllbin/LIBRARY.so,.dyliblib/ARCHIVE.lib.alib/Reference
Files touched (partial)
CMakeLists.txt(root; MSVC export config, install layout)extlib/portablexdr-4.9.1/CMakeLists.txt(runtime -> bindir)source/bin/CMakeLists.txt,source/plugins/CMakeLists.txtsource/{client,client2,server,server2}/CMakeLists.txtsource/serialisation/CMakeLists.txt(shared support and naming adjustments)source/wrappers/{c++,java}/CMakeLists.txtsource/wrappers/python/setup.py.in(naming and libraries list)source/wrappers/python/win.setup.py.in(naming consistency)Compatibility/impact
_staticsuffix) may require updates.*.exe,*.dllat Windows) install tobindir(e.g.,bin/), simplifying PATH setup and packaging.setup.py.innow aggregatesuda_libsin the libraries list (for Unix machines).Review checklist
install(TARGETS ...)?setup.py.inincludeuda_libscorrectly?extlib/portablexdrruntime placed underbindir?Test instructions
<prefix>/binand<prefix>/lib(64)setup.py.in; confirm the libraries list resolves viauda_libsand import succeedswin.setup.py.innaming matches built artifacts and dynamic import worksNotes
Related