Refactor plasma field calculations to use numba's njit for improved p…#4172
Merged
timothy-nunn merged 1 commit intomainfrom Apr 10, 2026
Merged
Refactor plasma field calculations to use numba's njit for improved p…#4172timothy-nunn merged 1 commit intomainfrom
timothy-nunn merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates plasma field helper functions to use Numba’s njit decorator (nopython mode) for improved JIT performance and stricter compilation guarantees within the physics model layer.
Changes:
- Replace
@nb.jit(cache=True)with@nb.njit(cache=True)on severalPlasmaFieldsstatic methods. - Ensure the affected plasma field calculations run in Numba nopython mode (consistent with other physics modules already using
njit/jit(nopython=True)).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4172 +/- ##
=======================================
Coverage 49.44% 49.44%
=======================================
Files 149 149
Lines 29796 29796
=======================================
Hits 14734 14734
Misses 15062 15062 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
approved these changes
Apr 10, 2026
grmtrkngtn
pushed a commit
that referenced
this pull request
Apr 13, 2026
grmtrkngtn
pushed a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erformance
Description
Checklist
I confirm that I have completed the following checks: