Add FwBlktVVShape enum and update blanket shape checks in models#4167
Add FwBlktVVShape enum and update blanket shape checks in models#4167timothy-nunn merged 1 commit intomainfrom
enum and update blanket shape checks in models#4167Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a typed enum to represent first-wall/blanket/vacuum-vessel shape options and updates several model shape-selection checks to use that enum instead of a raw numeric literal, improving readability and reducing “magic number” usage across geometry-related models.
Changes:
- Added
FwBlktVVShape(IntEnum) to representi_fw_blkt_vv_shapeoptions. - Replaced
fwbs_variables.i_fw_blkt_vv_shape == 1checks with== FwBlktVVShape.D_SHAPEDin multiple models.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| process/models/build.py | Adds the FwBlktVVShape enum definition. |
| process/models/vacuum.py | Updates vacuum vessel shape branching to use the enum constant. |
| process/models/shield.py | Updates shield shape branching to use the enum constant. |
| process/models/fw.py | Updates first wall shape branching to use the enum constant. |
| process/models/blankets/blanket_library.py | Updates blanket geometry branching to use the enum constant in two locations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4167 +/- ##
==========================================
+ Coverage 48.04% 48.05% +0.01%
==========================================
Files 144 144
Lines 30211 30219 +8
==========================================
+ Hits 14515 14523 +8
Misses 15696 15696 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Checklist
I confirm that I have completed the following checks: