Skip to content

Add FwBlktVVShape enum and update blanket shape checks in models#4167

Merged
timothy-nunn merged 1 commit intomainfrom
add_build_shape_enum
Apr 9, 2026
Merged

Add FwBlktVVShape enum and update blanket shape checks in models#4167
timothy-nunn merged 1 commit intomainfrom
add_build_shape_enum

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from a team as a code owner April 9, 2026 08:11
Copilot AI review requested due to automatic review settings April 9, 2026 08:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a typed enum to represent first-wall/blanket/vacuum-vessel shape options and updates several model shape-selection checks to use that enum instead of a raw numeric literal, improving readability and reducing “magic number” usage across geometry-related models.

Changes:

  • Added FwBlktVVShape (IntEnum) to represent i_fw_blkt_vv_shape options.
  • Replaced fwbs_variables.i_fw_blkt_vv_shape == 1 checks with == FwBlktVVShape.D_SHAPED in multiple models.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
process/models/build.py Adds the FwBlktVVShape enum definition.
process/models/vacuum.py Updates vacuum vessel shape branching to use the enum constant.
process/models/shield.py Updates shield shape branching to use the enum constant.
process/models/fw.py Updates first wall shape branching to use the enum constant.
process/models/blankets/blanket_library.py Updates blanket geometry branching to use the enum constant in two locations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.05%. Comparing base (09c52f5) to head (44a6b77).

Files with missing lines Patch % Lines
process/models/blankets/blanket_library.py 33.33% 2 Missing ⚠️
process/models/fw.py 50.00% 1 Missing ⚠️
process/models/shield.py 50.00% 1 Missing ⚠️
process/models/vacuum.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4167      +/-   ##
==========================================
+ Coverage   48.04%   48.05%   +0.01%     
==========================================
  Files         144      144              
  Lines       30211    30219       +8     
==========================================
+ Hits        14515    14523       +8     
  Misses      15696    15696              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Apr 9, 2026
@timothy-nunn timothy-nunn merged commit 75f0aae into main Apr 9, 2026
14 checks passed
@timothy-nunn timothy-nunn deleted the add_build_shape_enum branch April 9, 2026 15:52
grmtrkngtn pushed a commit that referenced this pull request Apr 13, 2026
grmtrkngtn pushed a commit that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants