Skip to content

Create diamagnetic current class#4156

Merged
timothy-nunn merged 6 commits intomainfrom
create_diamagnetic_current_class
Apr 9, 2026
Merged

Create diamagnetic current class#4156
timothy-nunn merged 6 commits intomainfrom
create_diamagnetic_current_class

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from a team as a code owner March 31, 2026 15:12
@chris-ashe chris-ashe added Physics Relating to the physics models Refactor labels Mar 31, 2026
@chris-ashe chris-ashe force-pushed the create_diamagnetic_current_class branch from 59f1dbb to 9355159 Compare March 31, 2026 15:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 68.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.08%. Comparing base (09c52f5) to head (f4a768a).

Files with missing lines Patch % Lines
process/models/physics/plasma_current.py 67.44% 14 Missing ⚠️
process/models/physics/physics.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4156      +/-   ##
==========================================
+ Coverage   48.04%   48.08%   +0.03%     
==========================================
  Files         144      144              
  Lines       30211    30243      +32     
==========================================
+ Hits        14515    14541      +26     
- Misses      15696    15702       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Apr 1, 2026
Copilot AI review requested due to automatic review settings April 7, 2026 08:12
@chris-ashe chris-ashe force-pushed the create_diamagnetic_current_class branch from 387eb16 to 8d1fc53 Compare April 7, 2026 08:12
@chris-ashe chris-ashe requested a review from timothy-nunn April 7, 2026 08:13

This comment was marked as resolved.

@timothy-nunn timothy-nunn merged commit 1a9dd1c into main Apr 9, 2026
10 checks passed
@timothy-nunn timothy-nunn deleted the create_diamagnetic_current_class branch April 9, 2026 09:11
grmtrkngtn pushed a commit that referenced this pull request Apr 13, 2026
* Add PlasmaDiamagneticCurrent class and integrate into Models and Physics

* Integrate PlasmaDiamagneticCurrent into unit tests for physics and stellarator

* Add PlasmaDiamagneticCurrentModel and update plot_proc to include its information

* Refactor PlasmaCurrentModel to use a dynamic class attribute for full_name

* Requested changes

* Refactor PlasmaDiamagneticCurrent methods to use njit for improved performance
grmtrkngtn pushed a commit that referenced this pull request Apr 13, 2026
* Add PlasmaDiamagneticCurrent class and integrate into Models and Physics

* Integrate PlasmaDiamagneticCurrent into unit tests for physics and stellarator

* Add PlasmaDiamagneticCurrentModel and update plot_proc to include its information

* Refactor PlasmaCurrentModel to use a dynamic class attribute for full_name

* Requested changes

* Refactor PlasmaDiamagneticCurrent methods to use njit for improved performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Physics Relating to the physics models Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants