Skip to content

Remove CMake - #3842

Merged
timothy-nunn merged 6 commits into
mainfrom
remove-cmake
Sep 16, 2025
Merged

timothy-nunn merged 6 commits into
mainfrom
remove-cmake

Conversation

@timothy-nunn

Copy link
Copy Markdown
Collaborator

Removes CMake and updates the appropriate scripts and documentation to "work" in the meantime. This is not a fully-inclusive PR and there is still significant work to completely update the docs etc.

@codecov-commenter

codecov-commenter commented Sep 10, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.78218% with 158 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.66%. Comparing base (5e8f1f9) to head (5f06192).

Files with missing lines Patch % Lines
process/io/data_structure_dicts.py 21.10% 157 Missing ⚠️
process/io/mfile_comparison.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3842      +/-   ##
==========================================
- Coverage   46.85%   46.66%   -0.19%     
==========================================
  Files         122      122              
  Lines       27617    27804     +187     
==========================================
+ Hits        12939    12976      +37     
- Misses      14678    14828     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
timothy-nunn marked this pull request as ready for review September 10, 2025 12:09
@timothy-nunn timothy-nunn self-assigned this Sep 10, 2025

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

Comment thread documentation/installation/introduction.md Outdated
Comment thread documentation/installation/installation.md Outdated
Comment thread documentation/installation/installation.md Outdated
Comment thread documentation/installation/installation.md Outdated
Comment thread documentation/installation/vs-code.md
Comment thread documentation/development/debugging.md Outdated
Comment thread documentation/development/pre-commit.md Outdated
Comment thread documentation/development/standards.md Outdated
Comment thread process/io/python_fortran_dicts.py Outdated
Comment thread process/io/python_fortran_dicts.py

@jonmaddock jonmaddock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Tim, nearly there! Thanks @clmould for finding loads of stuff I wouldn't have.

Comment thread process/io/python_fortran_dicts.py Outdated
Comment thread process/io/python_fortran_dicts.py
Comment thread tracking/tracking_data.py
The get_dicts() now does what dict creation build-time scripts did. Instead of writing a file, the dicts are created when get_dicts is first called and are cached for a given Python PROCESS
The tracker now requires tracking config to be of the form <arbitrary namespace>.<MFile variable>
@timothy-nunn
timothy-nunn merged commit 68d8058 into main Sep 16, 2025
18 checks passed
@timothy-nunn
timothy-nunn deleted the remove-cmake branch September 16, 2025 07:36
This was referenced Sep 17, 2025
grmtrkngtn pushed a commit that referenced this pull request Oct 10, 2025
* Remove build-time creation of dicts

The get_dicts() now does what dict creation build-time scripts did. Instead of writing a file, the dicts are created when get_dicts is first called and are cached for a given Python PROCESS

* Remove CMake

* Remove FORD docs

* Remove automatic Fortran namespacing from tracker

The tracker now requires tracking config to be of the form <arbitrary namespace>.<MFile variable>

* Update docs to remove references to CMake and Fortran

* Remove empty utilities package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants