1431 eff tf cryo needs to be an input but keeping the existing default values#3492
Open
jmorris-uk wants to merge 2 commits intomainfrom
Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
==========================================
- Coverage 30.27% 30.26% -0.01%
==========================================
Files 80 80
Lines 19501 19506 +5
==========================================
Hits 5903 5903
- Misses 13598 13603 +5 ☔ View full report in Codecov by Sentry. |
jonmaddock
requested changes
Feb 3, 2025
Contributor
jonmaddock
left a comment
jonmaddock
left a comment
There was a problem hiding this comment.
All fine, just a comment to clarify please.
| ) | ||
|
|
||
| # Cryo-plants efficiencies | ||
| if abs(tfcoil_variables.eff_tf_cryo + 1) < 1e-6: |
Contributor
There was a problem hiding this comment.
Could you comment on the significance of this if?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds correct outputting of the cryoplant efficiency from issue #1431
Checklist
I confirm that I have completed the following checks: