fix: 删除默认icon，添加删除逻辑，修复初始化时销毁无法删除图层，添加ts定义，修改基本用法例子 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
需要把useLayoutEffect的一起push上来，还是一会儿我再来一个pr |
jaywcjlove
reviewed
Dec 5, 2023
| // // 图片相对 position 的锚点，默认为 bottom-center | ||
| // anchor: 'center', | ||
| // }; | ||
| // } | ||
|
|
There was a problem hiding this comment.
这里上次讨论的不太深入。首先官方给的demo里是没有icon的。
我这边用的也是没icon的，就是纯文字，显示子市场。
所以我认为这个东西默认应该是没icon的，我也在给到的demo里更新了示例。
还有一个关键点就是即便是我有icon，也不会去用这里给到的默认icon，必然会让UI切一个。
你要是觉得得默认icon这里我就改回去- -
There was a problem hiding this comment.
@starInEcust 😯，我们的应用场景是默认有个 icon ，需要兼容老的版本
可以修改这一句
const { visiable, children, text, icon = initIcon, ...other } = props;这样兼容老的使用，不会影响你的使用，当没有传递 icon 的显示 默认 initIcon, icon=null 的时候就可以默认不显示图标
jaywcjlove
added a commit
that referenced
this pull request
Dec 5, 2023
|
@starInEcust 已经修改了 icon ，我们在更新的时候原则上不破坏过去的 API，如果破坏了过去的 API， 我们需要发个大版本 |
jaywcjlove
added a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.