feat: let callers pass extra zizmor arguments - #4
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the shared Scan reusable workflow to let calling repositories provide additional zizmor CLI flags (e.g., to disable online audits when private actions prevent tag listing with the default CI token).
Changes:
- Adds a new
workflow_callinput (zizmor-args) to accept extrazizmorarguments. - Threads the input into the
zizmorDocker invocation via an environment variable.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Audit workflow security | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| ZIZMOR_EXTRA_ARGS: ${{ inputs.zizmor-args }} |
Comment on lines
+87
to
+90
| # $ZIZMOR_EXTRA_ARGS word-splits by design; it carries flags, not data. | ||
| docker run --rm -e GH_TOKEN -v "$PWD:/repo" \ | ||
| ghcr.io/zizmorcore/zizmor@sha256:863026d54f91271b10b60b67ad8054cb37120167e162482597db102b3026a284 \ | ||
| /repo # 1.29.0 | ||
| $ZIZMOR_EXTRA_ARGS /repo # 1.29.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
zizmor 1.29.0 hard-errors when any tag-listing audit meets an action in a repository the CI token cannot read; attach pins the private first-party
uinaf/tessl-publish-action, and disabling audits one by one guts the scanner.Solution
A
zizmor-argsworkflow_callinput (env-indirected into the run to avoid template expansion) so a repository with a documented need passes--no-online-auditswhile every other adopter keeps full coverage.🤖 Generated with Claude Code