feat: use sinon 4 instead of 1 in test config #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes no difference in the actually implemented minimal tests, but is a much better starting point for apps. This only affects the new versions from 1.124, which are using the UI5 Test Starter. Fixes #34
Collaborator
Author
|
Clarifying whether we can use newer versions although they are not contained in the UI5 thirdparty folder. 4 is not that new either. |
Collaborator
Author
|
v4 is still embarrassingly old, but the newest one officially included in UI5. There is v14 in the core's test resources, but NOT meant to be exposed to be widely used. Only for Core's own tests. For external consumption, the go-to way is drafted in https://github.com/SAP/openui5-sample-app/pull/206/files: adding sinon as external dependency and using it via ui5-tooling-modules. |
Collaborator
Author
|
Newer sinon versions can only be used with future UI5 versions including UI5/openui5@b1737b0, so lt's merge this as fallback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes no difference in the actually implemented minimal tests, but
is a better starting point for apps.
This only affects the new versions from 1.124, which are using the UI5
Test Starter.
Fixes #34