Skip to content

Exclude the generated coverage folder from transpilation #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akudev wants to merge 1 commit into from
Closed

Exclude the generated coverage folder from transpilation #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion generators/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ export default class extends Generator {
}

// more relevant parameters
this.config.set("gte11150", semver.gte(props.frameworkVersion, "1.115.0"));
this.config.set("gte1_98_0", semver.gte(props.frameworkVersion, "1.98.0"));
this.config.set("gte1_104_0", semver.gte(props.frameworkVersion, "1.104.0"));
this.config.set("gte1_115_0", semver.gte(props.frameworkVersion, "1.115.0"));
});
}

Expand Down
2 changes: 1 addition & 1 deletion generators/app/templates/webapp/Component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import UIComponent from "sap/ui/core/UIComponent";
import models from "./model/models";<% if (gte11150) { %>
import models from "./model/models";<% if (gte1_115_0) { %>
import Device from "sap/ui/Device";<% } else { %>
import * as Device from "sap/ui/Device"; // for UI5 >= 1.115.0 use: import Device from "sap/ui/Device";<% } %>

Expand Down
2 changes: 1 addition & 1 deletion generators/app/templates/webapp/model/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import JSONModel from "sap/ui/model/json/JSONModel";
import BindingMode from "sap/ui/model/BindingMode";
<% if (gte11150) { %>
<% if (gte1_115_0) { %>
import Device from "sap/ui/Device";
<% } else { %>
import * as Device from "sap/ui/Device"; // for UI5 >= 1.115.0 use: import Device from "sap/ui/Device";
Expand Down
23 changes: 21 additions & 2 deletions generators/app/templates/webapp/view/Main.view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,26 @@
core:require="{
formatter: '<%= appURI %>/model/formatter'
}">

<% if (gte1_98_0) { %>
<Page
title="{i18n>appTitle}"
id="page">
<content>
<IllustratedMessage
title="{i18n>appTitle}"
illustrationType="sapIllus-SuccessHighFive"<% if (gte1_104_0) { %>
enableVerticalResponsiveness="true"<% } %>
description="{i18n>appDescription}">
<additionalContent>
<Button
id="helloButton"
text="{formatter: 'formatter.formatValue', path: 'i18n>btnText'}"
press="sayHello" />
</additionalContent>
</IllustratedMessage>
</content>
</Page>
<% } else { %>
<MessagePage
title="{i18n>appTitle}"
text="{i18n>appTitle}"
Expand All @@ -21,5 +40,5 @@
press="sayHello" />
</buttons>
</MessagePage>

<% } %>
</mvc:View>